Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pre-commit hooks #14

Merged
merged 2 commits into from
Nov 10, 2023
Merged

chore: pre-commit hooks #14

merged 2 commits into from
Nov 10, 2023

Conversation

0xste
Copy link
Collaborator

@0xste 0xste commented Nov 10, 2023

added pre-commit hooks for linting & conventional-commits

@0xste 0xste marked this pull request as ready for review November 10, 2023 10:31
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xste. Generally looks good. Just curious what's your rationale for this specific set of linters?

@0xste
Copy link
Collaborator Author

0xste commented Nov 10, 2023

@aaronc spotted you folks already used conventional commits + this generally tends to be my standard workflow for go projects. It would be nice to get the CI for tagging semver and publishing tagged versions for this setup too, something i may look at proposing in a subsequent MR 🙏

@0xste
Copy link
Collaborator Author

0xste commented Nov 10, 2023

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I don't have a strong opinion on linters so fine with merging this.

@aaronc aaronc merged commit cd806b2 into regen-network:main Nov 10, 2023
2 checks passed
@aaronc
Copy link
Member

aaronc commented Nov 10, 2023

Thanks for your contribution @0xste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants